-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReferenceError: event is not defined - Firefox #230
Comments
I observe the same issue on FF. |
Thanks for reporting this! I'm going to try and take a look tonight / over the weekend / over the break. |
I tried testing XSelect v4.0.0-beta.2 on codesandbox with Firefox 63 & 65 and couldn't reproduce. https://codesandbox.io/s/kkw0nk5j6v (you might have to edit a file, & hit save for the server to start on codesandbox 🤷♂️ ) Could anyone provide more info or a reproduction? or an error stack trade screenshot?
|
+1 Very annoying. |
@Robdel12 screenshot if it helps. |
I can't reproduce this (Firefox 68) but I got an error from Sentry with this exact issue. What I found interesting was that looking at the code for __setDefaultValues() {
let canSet = !this.isDestroying && !this.isDestroyed;
if (canSet && this.get('value') == null) {
// `onChange` is the default event we use
this._handleAction('onChange', this._getValue(), event);
}
}, That Even more interesting is that in MDN there are some notes regarding to this (https://developer.mozilla.org/en-US/docs/Web/API/Window/event). Interesting, about compatibility... it says that Firefox started supporting this in version 63/65 but it was reverted. Also interesting is that the Sentry report I got was from a Firefox of version So I think only a subset of Firefox versions are affected by this? (maybe 64). Not sure the solution, but maybe explicitly invoke |
I have just installed from master branch and on firefox (any version) following error shows in developer console:
"ReferenceError: event is not defined"
The text was updated successfully, but these errors were encountered: