-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add failed testcase name in tap file #367
Conversation
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
With failed testcase: https://ci.adoptopenjdk.net/job/Grinder/6181/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I like this, thanks @sophia-guo ! I will leave the 2nd / final review for @renfeiw (as Lan has explicitly asked for it). On the topic of adding additional information to the TAP files, separate from this work (and not expected to be covered by this PR), I was recently wondering if we could also include the line of jtreg output that summarized the total testcases in the target.
|
scripts/resultsSum.pl
Outdated
my $failureTests = ""; | ||
foreach my $line (@lines) | ||
{ | ||
if ( $line =~ /TEST: /) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to match the 50 hyphens before and then the TEST:
11:44:10 --------------------------------------------------
11:44:12 TEST: java/util/stream/test/org/openjdk/tests/java/util/stream/FilterOpTest.java
This could be more reliable compared to only TEST:
. In an extreme case, if we have not only openjdk but also other folders in the buildlist, TEST:
is too general.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated. Trying with multiple line query doesn't work well ( works in my local environment and failed with builds). Decided just using the simple loop, which works and feels simple and straightforward.
78eecdf
to
35cb22e
Compare
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
2f9bd0b
to
975cc27
Compare
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Grinder in Eclipse temurin https://ci.eclipse.org/temurin-compliance/job/Grinder/2221/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Related adoptium/aqa-tests#4146
Signed-off-by: Sophia Guo sophia.gwf@gmail.com