Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spanish language support for About page content #2940

Merged
merged 12 commits into from
Jul 28, 2024

Conversation

Thebyren
Copy link
Contributor

@Thebyren Thebyren commented Jul 7, 2024

add spanish in about content

The original page was translated and interpreted according to the original content.
The structure and the message are respected.
Contribution rules were respected.

Checklist

  • contribution guidelines followed here

Copy link

netlify bot commented Jul 7, 2024

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit d04c5f4
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/66a1ce1ed88b3200085e1f88
😎 Deploy Preview https://deploy-preview-2940--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

a missing "y" was added
The header was written wrong, my mistake was translating it thinking it was part of the content
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.14%. Comparing base (47746af) to head (d04c5f4).
Report is 38 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2940      +/-   ##
==========================================
- Coverage   99.34%   99.14%   -0.20%     
==========================================
  Files          90       90              
  Lines        6970     4938    -2032     
  Branches      611      611              
==========================================
- Hits         6924     4896    -2028     
+ Misses         46       42       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Note I'm not a native speaker).

@karianna
Copy link
Contributor

@CarmenDelgadoEclipse Are you able to review?

Fixed lack of accent marks in several words and typing correction
@CarmenDelgadoEclipse
Copy link

@CarmenDelgadoEclipse Are you able to review?

@karianna I have added a minor comment about typo, LGTM too, thanks!

content/asciidoc-pages/about/index.es.adoc Outdated Show resolved Hide resolved
@karianna karianna merged commit c734e5b into adoptium:main Jul 28, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants