Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Rerun builds regardless the results #829

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Show Rerun builds regardless the results #829

merged 1 commit into from
Oct 30, 2023

Conversation

llxia
Copy link
Contributor

@llxia llxia commented Oct 19, 2023

resolved: #814

@llxia
Show Rerun builds regardless the results
78212e7 
resolved: adoptium#814
Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
@netlify
Copy link

netlify bot commented Oct 19, 2023 •
edited
Loading

✅ Deploy Preview for eclipsefdn-adoptium-trss ready!

Name Link
🔨 Latest commit 78212e7
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium-trss/deploys/65313df14091bc0009f1cb37
😎 Deploy Preview https://deploy-preview-829--eclipsefdn-adoptium-trss.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@llxia
Copy link
Contributor Author

llxia commented Oct 19, 2023

image

@llxia
Copy link
Contributor Author

llxia commented Oct 19, 2023

image

@llxia llxia requested a review from smlambert October 19, 2023 14:39
@llxia
Copy link
Contributor Author

llxia commented Oct 27, 2023

@smlambert could you review the PR? Thanks

smlambert
smlambert approved these changes Oct 29, 2023
View reviewed changes
Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (though we should add some doc that says it assumes that naming convention means expects a suffix of _rerun)

@karianna karianna merged commit 22c0cce into adoptium:master Oct 30, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smlambert smlambert smlambert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release Summary Report should display the Rerun build result
3 participants
@llxia @smlambert @karianna