Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort by start time #887

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Sort by start time #887

merged 1 commit into from
Jun 25, 2024

Conversation

Sangyoon21
Copy link
Contributor

A draft of the issue #837
I tried to make the table sort by the starting time.

Copy link

netlify bot commented Jun 25, 2024

Deploy Preview for eclipsefdn-adoptium-trss ready!

Name Link
🔨 Latest commit c0a496f
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium-trss/deploys/667ac15bb736fc0008f0754a
😎 Deploy Preview https://deploy-preview-887--eclipsefdn-adoptium-trss.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@smlambert
Copy link
Contributor

Looks like this PR creates the desired behaviour (as shown in this screengrab with the same build IDs are sorted by start time now, where they were not necessarily sorted that way before)
Screenshot 2024-06-25 at 9 33 28 AM

Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Sangyoon21 !
Could you change it to Ready for Review

@Sangyoon21 Sangyoon21 marked this pull request as ready for review June 25, 2024 14:37
@LongyuZhang LongyuZhang merged commit af4a85b into adoptium:master Jun 25, 2024
7 checks passed
@Sangyoon21 Sangyoon21 deleted the issue837 branch June 26, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants