Problem in getDependentLibs of Crypto test

[zzambers]

Running aqa-tests on our infra we see this problem:

...
getDependentLibs:
     [exec] --------------------------------------------
     [exec] path is set to /home/tester/aqa-tests/TKG/../TKG/lib
     [exec] task is set to default
     [exec] dependencyList is set to jtreg_6_1${openj9jtregtimeouthandler}
     [exec] --------------------------------------------
     [exec] Starting download third party dependent jars
     [exec] --------------------------------------------
     [exec] downloading dependent third party jars to /home/tester/aqa-tests/TKG/../TKG/lib
     [exec] downloaded dependent third party jars successfully

getJtreg:
    [mkdir] Created dir: /home/tester/aqa-tests/test-results/functional/security/Crypto
     [exec] gzip: jtreg_6_1.tar.gz: No such file or directory

BUILD FAILED
...

it seems there is some un-evaluated variable in dependencyList:

aqa-tests/functional/security/Crypto/build.xml

Line 82 in 440b4b1

<property name="LIB" value="${jtregTar}${openj9jtregtimeouthandler}"/>

https://github.com/adoptium/TKG/blob/8ab5268b80c61487264de925d00fb165b5f2421f/scripts/getDependencies.pl#L51

error comes from Cryptotest wrapper, not sure why it only affects us though
(I think error probably also causes not downloading rest of dependencies for other tests...)

[zzambers]

@sophia-guo Not sure what is function of openj9jtregtimeouthandler variable, so I don't know what is correct fix here, or if this is config issue on our side.

[sophia-guo]

openj9jtregtimeouthandler is specific to openj9|ibm impl. Need to check why you have this issue.

[sophia-guo]

Yes, might need to add this check

aqa-tests/openjdk/build.xml

Lines 72 to 83 in 440b4b1

	<if>
	<or>
	<equals arg1="${JDK_IMPL}" arg2="ibm" />
	<equals arg1="${JDK_IMPL}" arg2="openj9" />
	</or>
	<then>
	<property name="openj9jtregtimeouthandler" value=",tohandler_simple"/>
	</then>
	<else>
	<property name="openj9jtregtimeouthandler" value=""/>
	</else>
	</if>

. But curious why we didn't hit the issue in adoptium, checking now...

[zzambers]

I was also wondering, why this issue does not happen in adoptium runs...
Thanks for looking into this.

Btw. job, where we see this problem has following BUILD_LIST:
BUILD_LIST=system,perf,functional

[sophia-guo]

Yes, in adoptium we do the pre-staged jars so all jars have been staged before running the tests.
https://github.com/adoptium/aqa-tests/blob/master/buildenv/jenkins/JenkinsfileBase#L187-L195

Btw. job, where we see this problem has following BUILD_LIST:
BUILD_LIST=system,perf,functional

This should not affect it. So I believe the if block I mentioned in #4537 (comment) should solve this problem. Could you give it a try? Thanks.

[zzambers]

Ok, I'll make that change and try it. Thanks

[zzambers]

Fix has been merged, closing.