Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EXTRA_OPTIONS should append instead of prepend to the existing JVM options #4849

Closed
JasonFengJ9 opened this issue Nov 2, 2023 · 5 comments · Fixed by #4861
Closed

EXTRA_OPTIONS should append instead of prepend to the existing JVM options #4849

JasonFengJ9 opened this issue Nov 2, 2023 · 5 comments · Fixed by #4861

Comments

@JasonFengJ9
Copy link
Contributor

Currently the EXTRA_OPTIONS could be overridden by an existing JVM option, for example, -Xdump:java:events=vmstop is specified at EXTRA_OPTIONS, and the actual JVM command is -Xdump:java:events=vmstop ... -Xdump:system:none .... The option supplied has no effect.
The EXTRA_OPTIONS should append instead of prepend to the existing JVM options.

FYI @llxia
@llxia
Copy link
Contributor

llxia commented Nov 6, 2023

@annaibm could you take a look at this issue? Thanks

@llxia
Copy link
Contributor

llxia commented Nov 6, 2023

Please check where EXTRA_OPTIONS is contrustured and used. For example:
https://github.com/search?q=repo%3Aadoptium%2Faqa-tests%20system%3Anone&type=code

annaibm added a commit to annaibm/aqa-tests that referenced this issue Nov 10, 2023
@annaibm
User specfic extra_options appended to JVM options
2f90818 
-Updated in `JavaTestUtil.java` file and `JavaTestRunner.java` file to append user specified jvmOpts to exisitng jvm options

-Appended jvm options to file contents below:-
`fileContent += "set jck.env.compiler.compRefExecute.otherOpts \" " + extraJvmOptions + jvmOpts + " \"" + ";\n";`
`fileContent += "set jck.env.devtools.refExecute.otherOpts \" " + extraJvmOptions + " " + jvmOpts + " \"" + ";\n";`

Added the null pointer check for : -
`other.options` and `jvm.options`

resolves : adoptium#4849

Signed-off-by: Anna Babu Palathingal <anna.bp@ibm.com>
annaibm added a commit to annaibm/aqa-tests that referenced this issue Nov 10, 2023
@annaibm
User specfic extra_options appended to JVM options
716d47e 
- Append user specified jvmOpts to exisitng jvm options

- Added the null pointer check for other options and jvm options

resolves : adoptium#4849

Signed-off-by: Anna Babu Palathingal <anna.bp@ibm.com>
@annaibm annaibm mentioned this issue Nov 10, 2023
Merged
smlambert pushed a commit that referenced this issue Nov 17, 2023
@annaibm
User specfic extra_options appended to JVM options (#4861)
ec4ef4a 
- Append user specified jvmOpts to exisitng jvm options

- Added the null pointer check for other options and jvm options

resolves : #4849

Signed-off-by: Anna Babu Palathingal <anna.bp@ibm.com>
@llxia llxia reopened this Nov 17, 2023
@llxia
Copy link
Contributor

llxia commented Nov 17, 2023

The issue in openjdk did not get resolved yet.

annaibm added a commit to annaibm/aqa-tests that referenced this issue Nov 22, 2023
@annaibm
User specfic extra_options appended to JVM options (adoptium#4861)
37e1bc2 
- Append user specified jvmOpts to exisitng jvm options

- Added the null pointer check for other options and jvm options

resolves : adoptium#4849

Signed-off-by: Anna Babu Palathingal <anna.bp@ibm.com>
@llxia
Copy link
Contributor

llxia commented Nov 22, 2023

Thanks @annaibm's verification. In openjdk test,

aqa-tests/openjdk/openjdk.mk

Line 177 in 2ea383b

TEST_VARIATION_DUMP:=-Xdump:system:none -Xdump:heap:none -Xdump:system:events=gpf+abort+traceassert+corruptcache
, EXTRA_OPTIONS is appended.

image

This issue is resolved.

@llxia llxia closed this as completed Nov 22, 2023
@JasonFengJ9
Copy link
Contributor Author

Thank you @annaibm @llxia

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

EXTRA_OPTIONS are appended to exisiting JVM options annaibm/aqa-tests
2 participants
@JasonFengJ9 @llxia