Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Openj9 nightly CUSTOMIZED_SDK_URL #5947

Closed
llxia opened this issue Feb 7, 2025 · 1 comment · Fixed by #5948
Closed

Openj9 nightly CUSTOMIZED_SDK_URL #5947

llxia opened this issue Feb 7, 2025 · 1 comment · Fixed by #5948

Comments

@llxia
Copy link
Contributor

llxia commented Feb 7, 2025 •
edited
Loading

When setting CUSTOMIZED_SDK_URL for openj9 nightly, CUSTOMIZED_SDK_URL is expected to end with /. The pipeline will not work if the ending / is missing. (see link)

We should fix the code. If ending / is missing add it for the users.

https://github.com/adoptium/aqa-tests/blob/master/get.sh#L215
@llxia
Copy link
Contributor Author

llxia commented Feb 7, 2025

@dennycjacob can you work on this issue? Thanks

dennycjacob added a commit to dennycjacob/aqa-tests that referenced this issue Feb 11, 2025
@dennycjacob
Fix for CUSTOMIZED_SDK_URL path
8ebddf4 
This update is a fix for CUSTOMIZED_SDK_URL path . The script adds "/" at the end if it is missing
Fixes: adoptium#5947
Signed-off-by: Denny Chacko Jacob denny.cjacob@ibm.com
@dennycjacob dennycjacob mentioned this issue Feb 11, 2025
Merged
dennycjacob added a commit to dennycjacob/aqa-tests that referenced this issue Feb 11, 2025
@dennycjacob
Fix for CUSTOMIZED_SDK_URL path
e9b2a8b 
This update is a fix for CUSTOMIZED_SDK_URL path . The script adds "/" at the end if it is missing
Update indentation in get.sh
Fixes: adoptium#5947
Signed-off-by: Denny Chacko Jacob denny.cjacob@ibm.com
karianna pushed a commit that referenced this issue Feb 12, 2025
@dennycjacob
Fix for CUSTOMIZED_SDK_URL path (#5948)
a9f1c83 
This update is a fix for CUSTOMIZED_SDK_URL path . The script adds "/" at the end if it is missing
Update indentation in get.sh
Fixes: #5947
Signed-off-by: Denny Chacko Jacob denny.cjacob@ibm.com
@github-project-automation github-project-automation bot moved this from Todo to Done in Adoptium Backlog Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Adoptium Backlog
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for CUSTOMIZED_SDK_URL path issue dennycjacob/aqa-tests
1 participant
@llxia