-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Triage/Excluding tests #1348
Merged
Merged
Triage/Excluding tests #1348
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
0b392ee
Triaged/excluded tests
0d011f1
Excluded tests on JDK11 which were previously only excluded on 13
d1a56de
Excluded ClassForNameLeak on jdk8
e7518c3
Added issue for TimedAcquireLeak
5c1e012
Added issue for TestLoggerWeakRefLeak
5340bbf
Unexcluded ProcessBuilder/Basic on 8 and 11
e97f5b0
Unexclude CondyDescTest
4efd7b6
Merge branch 'master' into triage
adam-thorpe dbfb871
Unexcluded CustomSecurityManager
872f575
Merge branch 'triage' of https://github.com/adam-thorpe/openjdk-tests…
54cd9e3
Merge branch 'master' into triage
adam-thorpe File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,7 +38,6 @@ java/lang/ClassLoader/nativeLibrary/NativeLibraryTest.java https://github.com/Ad | |
java/lang/Enum/ConstantDirectoryOptimalCapacity.java https://github.com/eclipse/openj9/issues/6660 generic-all | ||
java/lang/ModuleLayer/BasicLayerTest.java https://github.com/eclipse/openj9/issues/6462 generic-all | ||
java/lang/ProcessBuilder/SkipTest.java https://github.com/eclipse/openj9/issues/4124 windows-all | ||
java/lang/SecurityManager/modules/CustomSecurityManager.sh https://github.com/eclipse/openj9/issues/6661 generic-all | ||
java/lang/StackTraceElement/PublicConstructor.java https://github.com/eclipse/openj9/issues/6659 generic-all | ||
java/lang/StackTraceElement/SerialTest.java https://github.com/eclipse/openj9/issues/6659 generic-all | ||
java/lang/StackWalker/Basic.java https://github.com/eclipse/openj9/issues/6698 generic-all | ||
|
@@ -298,14 +297,14 @@ java/rmi/transport/runtimeThreadInheritanceLeak/RuntimeThreadInheritanceLeak.jav | |
|
||
# jdk_util | ||
|
||
java/util/Arrays/TimSortStackSize2.java https://github.com/AdoptOpenJDK/openjdk-tests/issues/585 generic-all | ||
java/util/Arrays/TimSortStackSize2.java https://github.com/eclipse/openj9/issues/7086 generic-all | ||
java/util/Arrays/largeMemory/ParallelPrefix.java https://github.com/eclipse/openj9/issues/4100 linux-ppc64le | ||
java/util/BitSet/stream/BitSetStreamTest.java https://github.com/eclipse/openj9/issues/4720 linux-all | ||
java/util/Spliterator/SpliteratorCollisions.java https://github.com/AdoptOpenJDK/openjdk-tests/issues/585 generic-all | ||
java/util/concurrent/atomic/VMSupportsCS8.java https://github.com/AdoptOpenJDK/openjdk-tests/issues/585 generic-all | ||
java/util/Spliterator/SpliteratorCollisions.java https://github.com/eclipse/openj9/issues/7090 generic-all | ||
java/util/concurrent/ArrayBlockingQueue/WhiteBox.java https://github.com/eclipse/openj9/issues/5988 macosx-all | ||
java/util/concurrent/forkjoin/FJExceptionTableLeak.java https://github.com/eclipse/openj9/issues/3209 generic-all | ||
java/util/concurrent/locks/Lock/TimedAcquireLeak.java https://github.com/AdoptOpenJDK/openjdk-tests/issues/585 generic-all | ||
java/util/logging/TestLoggerWeakRefLeak.java https://github.com/AdoptOpenJDK/openjdk-tests/issues/585 generic-all | ||
java/util/concurrent/locks/Lock/TimedAcquireLeak.java https://github.com/eclipse/openj9/issues/7125 macosx-all,linux-all | ||
java/util/logging/TestLoggerWeakRefLeak.java https://github.com/AdoptOpenJDK/openjdk-tests/issues/1352 generic-all | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same comment as above, let's amalgamate all non-applicable permanent excludes under 1297 |
||
java/util/logging/LogManager/TestLoggerNames.java https://github.com/eclipse/openj9/issues/4561 generic-all | ||
java/util/stream/boottest/java.base/java/util/stream/NodeTest.java https://github.com/eclipse/openj9/issues/4129 macosx-all | ||
java/util/stream/test/org/openjdk/tests/java/util/SplittableRandomTest.java https://github.com/eclipse/openj9/issues/4613 generic-all | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,8 +25,8 @@ | |
java/lang/Class/forName/NonJavaNames.sh https://github.com/eclipse/openj9/issues/1128 generic-all | ||
java/lang/Class/forName/arrayClass/ExceedMaxDim.java https://github.com/eclipse/openj9/issues/1128 generic-all | ||
java/lang/ClassLoader/Assert.java https://github.com/AdoptOpenJDK/openjdk-tests/issues/982 aix-all | ||
java/lang/ClassLoader/forNameLeak/ClassForNameLeak.java https://github.com/eclipse/openj9/issues/7122 generic-all | ||
java/lang/Math/HypotTests.java https://github.com/eclipse/openj9/issues/1128 generic-all | ||
java/lang/ProcessBuilder/Basic.java https://github.com/eclipse/openj9/issues/1128 generic-all | ||
java/lang/Runtime/shutdown/ShutdownInterruptedMain.java https://github.com/eclipse/openj9/issues/1128 generic-all | ||
java/lang/SecurityManager/CheckPackageAccess.java https://github.com/eclipse/openj9/issues/1128 generic-all | ||
java/lang/String/CaseConvertSameInstance.java https://github.com/eclipse/openj9/issues/3303 generic-all | ||
|
@@ -302,13 +302,13 @@ java/util/Spliterator/SpliteratorCollisions.java https://github.com/eclipse/ope | |
java/util/SplittableRandom/SplittableRandomTest.java https://github.com/AdoptOpenJDK/openjdk-tests/issues/830 linux-ppc64le | ||
java/util/TimeZone/HongKong.java https://bugs.openjdk.java.net/browse/JDK-8031145 generic-all | ||
java/util/Timer/NameConstructors.java https://github.com/AdoptOpenJDK/openjdk-tests/issues/821 windows-all | ||
java/util/concurrent/atomic/VMSupportsCS8.java https://github.com/eclipse/openj9/issues/1131 generic-all | ||
java/util/concurrent/atomic/VMSupportsCS8.java https://github.com/AdoptOpenJDK/openjdk-tests/issues/1347 generic-all | ||
java/util/concurrent/locks/Lock/TimedAcquireLeak.java https://github.com/eclipse/openj9/issues/1131 generic-all | ||
java/util/concurrent/ThreadLocalRandom/ThreadLocalRandomTest.java https://github.com/AdoptOpenJDK/openjdk-tests/issues/830 linux-all | ||
java/util/concurrent/ThreadPoolExecutor/CoreThreadTimeOut.java https://github.com/AdoptOpenJDK/openjdk-tests/issues/821 windows-all | ||
java/util/logging/CheckZombieLockTest.java https://github.com/AdoptOpenJDK/openjdk-tests/issues/830 generic-all | ||
java/util/logging/FileHandlerMaxLocksTest.java https://github.com/eclipse/openj9/issues/1131 generic-all | ||
java/util/logging/TestLoggerWeakRefLeak.java https://github.com/eclipse/openj9/issues/1131 generic-all | ||
java/util/logging/TestLoggerWeakRefLeak.java https://github.com/AdoptOpenJDK/openjdk-tests/issues/1352 generic-all | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
java/util/logging/TestLoggingWithMainAppContext.java https://github.com/AdoptOpenJDK/openjdk-tests/issues/830 macosx-all | ||
java/util/logging/TestMainAppContext.java https://github.com/AdoptOpenJDK/openjdk-tests/issues/830 macosx-all | ||
java/util/prefs/PrefsSpi.sh https://github.com/eclipse/openj9/issues/1131 generic-all | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can add this 1352 link to the ones marked in #1297, close 1352 and use the 1297 link for tests that are permanent excludes due to them being hotspot specific.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I was waiting for clarification if these tests were hotspot specific or not before adding them to the permanent exclude list. So are these tests both to be perma excluded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When i say these i mean this test on all 3 lists and also #1347