-
-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Excluding ResetPeakMemoryUsage on openj9 #2328
Conversation
Thanks @psoujany, some initial questions:
|
Is ResetPeakMemoryUsage a part of Do we have a plan to re-enable |
Thank you. |
Hi @llxia This testcase is also not supported on openj9, so even in future enabling jdk_management this testcase would fail. Hence exclusion would be valid fix. |
So it sounds like in this case that this is a permanent exclude (the test case is not valid for openj9). For permanent excludes, then please change the URL from the internal one (runtimes/openj9-openjdk-jdk11-zos/issues/454) that we have no visibility of to I see the confusion, when I referred to 'open issue' I meant an issue in an open-source repo (not an internal repo) that is visible to everyone (and can be queried by automation we will run from the open-source projects). :) |
@@ -133,7 +133,7 @@ sun/management/HotspotRuntimeMBean/GetSafepointCount.java https://github.com/Ado | |||
sun/management/HotspotRuntimeMBean/GetSafepointSyncTime.java https://github.com/AdoptOpenJDK/openjdk-tests/issues/932 generic-all | |||
sun/management/HotspotRuntimeMBean/GetTotalSafepointTime.java https://github.com/AdoptOpenJDK/openjdk-tests/issues/932 generic-all | |||
sun/management/HotspotThreadMBean/GetInternalThreads.java https://github.com/AdoptOpenJDK/openjdk-tests/issues/932 generic-all | |||
|
|||
java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java https://github.ibm.com/runtimes/openj9-openjdk-jdk11-zos/issues/454 generic-all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@psoujany - please use https://github.com/AdoptOpenJDK/openjdk-tests/issues/1297
instead of the https://github.ibm.com/runtimes/openj9-openjdk-jdk11-zos/issues/454
internal issue
Hi, @ShelleyLambert. I applied change as you mentioned to all releases i.e, jdk11+. Please review the changes. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @psoujany
@llxia - anything further updates you would like to see on this PR, or are we good ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR is to exclude hotspot related jdk_management test on openj9.
java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java - exclusion on openj9 for jdk11