Removed JRE_IMAGE in openjdk.mk

[akanbifatimah]

I have removed the JRE_IMAGE in openjdk.mk. Thank you.

[llxia]

@akanbifatimah Thanks for the PR. Please create a separate PR for Added DYNAMIC_COMPILE in testJobTemplate

[llxia]

@akanbifatimah I see your PR #3037 for Added DYNAMIC_COMPILE in testJobTemplate. Please remove the testJobTemplate change from this PR. Thanks.

[akanbifatimah]

Thank you Lan, but I am a bit confused, the good issue task #3031, am i to undo the change "for Added DYNAMIC_COMPILE"?

…

On Wed, Oct 20, 2021 at 3:00 PM Lan Xia ***@***.***> wrote: @akanbifatimah <https://github.com/akanbifatimah> I see your PR #3037 <#3037> for Added DYNAMIC_COMPILE in testJobTemplate. Please remove the testJobTemplate change from this PR. Thanks. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3036 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AR6DACCYDQLQTVYUD242YMLUH3DRRANCNFSM5GKB5V4A> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[llxia]

You, you have two PRs - this one and #3037. DYNAMIC_COMPILE change is in both PRs. Since this PR is for Removed JRE_IMAGE, please remove DYNAMIC_COMPILE change from this PR.

[akanbifatimah]

Thank you so much for your guidance, I understand now and will effect it immediately, thank you once again.

[smlambert]

See the 3 minute recording from the pinned post in outreachy Slack channel (re: best practices to start each new branch in sync with master and free from changes from previous PRs).

[akanbifatimah]

Thank you @shelly, I now understand better, thank you for always. I have removed the changed from the Pr too

…

On Wed, Oct 20, 2021 at 10:03 PM Shelley Lambert ***@***.***> wrote: See the 3 minute recording <https://drive.google.com/file/d/1yTcXaA8vHgHMkkuDONKeDCEufgZJO-TJ/view?usp=sharing> from the pinned post in outreachy Slack channel (re: best practices to start each new branch in sync with master and free from changes from previous PRs). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3036 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AR6DACAHNRNGX3LOWHUQZ53UH4VAPANCNFSM5GKB5V4A> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[llxia]

Running Grinder: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/2168/

Update:

00:04:28.161  ===============================================
00:04:28.161  Running test jdk_math_jre_0 ...
00:04:28.161  ===============================================
00:04:28.161  jdk_math_jre_0 Start Time: Fri Oct 29 16:22:51 2021 Epoch Time (ms): 1635524571304
00:04:28.161  Nothing to be done for setup.
00:04:28.161  variation: Mode150
00:04:28.161  JVM_OPTIONS:  -XX:+UseCompressedOops 
00:04:28.161  { itercnt=1; \
00:04:28.161  mkdir -p "/home/jenkins/workspace/Grinder/aqa-tests/TKG/../TKG/output_16355244408780/jdk_math_jre_0"; \
00:04:28.161  cd "/home/jenkins/workspace/Grinder/aqa-tests/TKG/../TKG/output_16355244408780/jdk_math_jre_0"; \
00:04:28.161  "/home/jenkins/workspace/Grinder/openjdkbinary/j2sdk-image/bin/java" -Xmx512m -jar "/home/jenkins/workspace/Grinder/aqa-tests/TKG/../../jvmtest/openjdk/jtreg/lib/jtreg.jar" \
00:04:28.161  -agentvm -a -ea -esa -v:fail,error,time,nopass -retain:fail,error,*.dmp,javacore.*,heapdump.*,*.trc -ignore:quiet -timeoutFactor:8 -xml:verify -concurrency:3 -k:'!headful'  -vmoptions:"-Xmx512m  -XX:+UseCompressedOops  -Djava.awt.headless=true" \
00:04:28.161  -w ""/home/jenkins/workspace/Grinder/aqa-tests/TKG/../TKG/output_16355244408780/jdk_math_jre_0"/work" \
00:04:28.161  -r "/home/jenkins/workspace/Grinder/aqa-tests/TKG/../../jvmtest/openjdk/report" \
00:04:28.161  -compilejdk:"/home/jenkins/workspace/Grinder/openjdkbinary/j2sdk-image" \
00:04:28.161  -jdk:"/home/jenkins/workspace/Grinder/openjdkbinary/j2re-image" \
00:04:28.161  -exclude:"/home/jenkins/workspace/Grinder/aqa-tests/TKG/../openjdk/openjdk-jdk/jdk/test/ProblemList.txt" \
00:04:28.162  -exclude:"/home/jenkins/workspace/Grinder/aqa-tests/TKG/../../jvmtest/openjdk/excludes/ProblemList_openjdk8.txt" \
00:04:28.162  "/home/jenkins/workspace/Grinder/aqa-tests/TKG/../openjdk/openjdk-jdk/jdk/test:jdk_math"; \
00:04:28.162  if [ $? -eq 0 ] ; then echo ""; echo "jdk_math_jre_0""_PASSED"; echo ""; cd /home/jenkins/workspace/Grinder/aqa-tests/TKG/..;  else echo ""; echo "jdk_math_jre_0""_FAILED"; echo ""; fi; } 2>&1 | tee -a "/home/jenkins/workspace/Grinder/aqa-tests/TKG/../TKG/output_16355244408780/TestTargetResult";
00:04:28.162  Directory "/home/jenkins/workspace/Grinder/aqa-tests/TKG/../TKG/output_16355244408780/jdk_math_jre_0/work" not found: creating
00:04:28.162  XML output with verification to /home/jenkins/workspace/Grinder/aqa-tests/TKG/output_16355244408780/jdk_math_jre_0/work
00:05:34.708  Test results: passed: 37
00:05:34.708  Report written to /home/jenkins/workspace/Grinder/jvmtest/openjdk/report/html/report.html
00:05:34.708  Results written to /home/jenkins/workspace/Grinder/aqa-tests/TKG/output_16355244408780/jdk_math_jre_0/work
00:05:34.708  
00:05:34.708  jdk_math_jre_0_PASSED

[llxia]

LGTM

[smlambert]

thanks @akanbifatimah !

[akanbifatimah]

Thank you @smlambert and @llxia , I learnt new things from the project