Add jdk_lang_VarHandleTest_j9 test #3100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test Links: |
llxia
requested changes
Oct 26, 2021
openjdk/playlist.xml
Outdated
| -w $(Q)$(REPORTDIR)$(D)work$(Q) \ | ||
| -r $(Q)$(TEST_RESROOT)$(D)report$(Q) \ | ||
| -jdk:$(Q)$(TEST_JDK_HOME)$(Q) \ | ||
| $(Q)$(OPENJDK_DIR)$(D)test$(D)jdk$(D)java$(D)lang$(D)invoke$(D)VarHandles$(Q); \ |
There was a problem hiding this comment.
$(D) is not necessary. We do not need to use it
There was a problem hiding this comment.
Updated to use /, thanks
| <group>openjdk</group> | ||
| </groups> | ||
| <impls> | ||
| <impl>openj9</impl> |
| @@ -577,6 +577,33 @@ | |||
| <impl>ibm</impl> | |||
| </impls> | |||
| </test> | |||
| <test> | |||
| <testCaseName>jdk_lang_VarHandleTest_j9</testCaseName> | |||
There was a problem hiding this comment.
- jdk_lang_VarHandleTest_j9 needs to be excluded in jdk_lang
- jit opt is a temporary solution. Please add a comment about it
There was a problem hiding this comment.
Comment about temporary solution with jit opt has been added.
Excluding VarHandleTests are in another PR: #3101.
New test links: win: 19057 plinux: 19058
- Add jdk_lang_VarHandleTest_j9 test with specific jit option Signed-off-by: Longyu Zhang <longyu.zhang@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Longyu Zhang longyu.zhang@ibm.com