Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable TestFunctionDescriptor in JDK17/18/19+ #4050

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Enable TestFunctionDescriptor in JDK17/18/19+ #4050

merged 1 commit into from
Oct 20, 2022

Conversation

ChengJin01
Copy link

Signed-off-by: Cheng Jin jincheng@ca.ibm.com

@ChengJin01
Copy link
Author

ChengJin01 commented Oct 18, 2022 •
edited
Loading

Reviewer: @llxia
FYI: @ShelleyLambert, @tajila, @pshipton

@ChengJin01 ChengJin01 mentioned this pull request Oct 18, 2022
Closed
@ChengJin01
Copy link
Author

ChengJin01 commented Oct 18, 2022 •
edited
Loading

@llxia, please help run Jenkins (specifically for jdk_foreign_1 on macOS/Aarch64) to see whether it passes in JDK17/18/19+ given the issue was resolved.

@llxia
Copy link
Contributor

llxia commented Oct 18, 2022

on JDK17 aarch64_mac: internal/Grinder/28685

@ChengJin01 please feel free to launch Grinder on other platforms and versions. Thanks

@ChengJin01 ChengJin01 force-pushed the enable_ffi_foreign_testfunctiondescriptor branch from a96dc5c to 53bcd97 Compare October 18, 2022 16:46
@ChengJin01
Copy link
Author

I'd like to remove the disables option for jdk_foreign in playlist.xml as it prevents normal FFI tests from being executed (except the disabled tests).

@ChengJin01
Copy link
Author

Launched Grinders in JDK17/18/19+ on all supported platforms via internal/Grinder/28710.

Enable TestFunctionDescriptor in JDK17/18/19+
acf6bfc 
Signed-off-by: Cheng Jin <jincheng@ca.ibm.com>
@ChengJin01 ChengJin01 force-pushed the enable_ffi_foreign_testfunctiondescriptor branch from 53bcd97 to acf6bfc Compare October 18, 2022 18:46
@ChengJin01
Copy link
Author

ChengJin01 commented Oct 18, 2022 •
edited
Loading

I disabled a couple of downcall & upcall related test suites in JDK19+ given the disables option for jdk_foreign was removed in playlist.xml. These tests need to be verified on all supported platforms before re-enabling them.

@ChengJin01
Copy link
Author

Launched another Grinder in JDK17/18/19+ on all supported platforms via internal/Grinder/28757.

@ChengJin01
Copy link
Author

The Grinder at internal/Grinder/28685 works good as expected and there is no issue detected at internal/Grinder/28757 except those Grinders which failed to launch.

So the PR is safe to merge.

llxia
llxia approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

LongyuZhang
LongyuZhang approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongyuZhang LongyuZhang merged commit b92baa6 into adoptium:master Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llxia llxia llxia approved these changes

@LongyuZhang LongyuZhang LongyuZhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChengJin01 @llxia @LongyuZhang