-
-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove extra space in Rerun build with failed targets link #4074
Conversation
…/aqa-tests into remove-unwanted-space "Updated the branch from upstream"
Hello, @smlambert I hope everything is good with you. |
Hello @smlambert I'm yet to get a response from you. |
@Nuel-Eneji could you please remove the changes under .github/ISSUE_TEMPLATE? I believe they are not related to the fix of #4063 |
Hello @llxia sorry for the inconvinience, I've reverted the changes as made. |
buildenv/jenkins/JenkinsfileBase
Outdated
@@ -1073,7 +1073,7 @@ def addFailedTestsGrinderLink(paths=""){ | |||
def failedTestList = "" | |||
List<String> buildPaths = paths.split(',') | |||
for (def buildPath: buildPaths) { | |||
def tapFiles = findFiles(glob: "${buildPath}**/*.tap") | |||
def tapFiles = findFiles(glob: "${buildPath.trim()}**/*.tap") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will not fix the problem. I think trim()
should be added at L1084
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @llxia I'll get on with that now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @llxia Thanks for the review. Please i need further guidiance on this
Thanks
Hello @smlambert @llxia I moved the |
https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/6071/
The issue happens in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Input trim() to check trailing whitespace
I added the trim() to remove whitespace before and after the string
this draft PR attempts to fix issue #4063
singed-off-by: Nuel Eneji enejiemmanueladie@gmail.com