Enhanced pre/post test job hung/leftover process checking #4185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
|
Test Grinders:
|
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
llxia
reviewed
Dec 5, 2022
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
|
@AdamBrousseau could you also review this PR? Thanks |
karianna
previously requested changes
Dec 7, 2022
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
sxa
requested changes
Dec 7, 2022
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
sxa
reviewed
Dec 8, 2022
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
Signed-off-by: Andrew Leonard <anleonar@redhat.com>
sxa
approved these changes
Dec 8, 2022
|
@AdamBrousseau Hi Adam, if you could take a look as well please, as another CI user, thanks |
|
zos Grinder |
karianna
approved these changes
Dec 9, 2022
| } else { | ||
| sh(script:'ps -fu '+"${env.USER}"+' | grep java | egrep -v "remoting.jar|agent.jar|grep"', returnStatus:true) | ||
| } | ||
| def statusCode=sh(script:"aqa-tests/terminateTestProcesses.sh ${env.USER} 2>&1", returnStatus:true) |
There was a problem hiding this comment.
Suggested change
| def statusCode=sh(script:"aqa-tests/terminateTestProcesses.sh ${env.USER} 2>&1", returnStatus:true) | |
| def statusCode = sh(script:"aqa-tests/terminateTestProcesses.sh ${env.USER} 2>&1", returnStatus:true) |
|
Sorry I didn't get a chance to finish reviewing before merge. I am happy with it assuming it's been tested on all the platforms. We'll keep an eye out. We have a "sanitize" job we run a few times a day. This might allow us to disable that. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4184
Enhances the pre/post PROCESSCATCH logic checking for more left over processes, in particular:
Enhanced to better filter Jenkins Agent process, and utilise Windows enhanced powershell queries.