-
-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support rerun failed jdk | hotspot testcases in Grinder with jdk_custom | hotspot_custom target #4284
Conversation
Depends on adoptium/TKG#397 #4283 |
4bdc53e
to
a3dce5a
Compare
Grinder with jdk_custom https://ci.adoptopenjdk.net/job/Grinder/6527/ |
Parallel grinder: https://ci.adoptopenjdk.net/job/Grinder/6532/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Sophia Guo <sophia.gwf@gmail.com>
Parallel Grinder result does not capture all of the CUSTOM_TARGET values that are reported in TAP files:
But I only see |
There are two links - jdk_custom and hotspot_custom. Rerun failed jdk test cases in Grinder with jdk_custom target That three tests belong to jdk group and are set in jdk_custom link. |
Ah, thanks @sophia-guo, I should have paid more attention! Thanks for these Grinders! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I should have tested this on openj9 and hyc Jenkins. I was too excited about the PR. For the record, when using new Jenkins libraries/APIs, we need to test on all Jenkins to ensure the permission is set correctly. See eclipse-openj9/openj9#16649 |
close #4265
Signed-off-by: Sophia Guo sophia.gwf@gmail.com