Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid using realpath for tck root #4287

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

Mesbah-Alam
Copy link
Contributor

  • Avoid using realpath while on Cygwin
  • Fixes : backlog/issues/1016.

Signed-off-by: Mesbah Alam Mesbah_Alam@ca.ibm.com

Signed-off-by: Mesbah Alam <Mesbah_Alam@ca.ibm.com>
@Mesbah-Alam
Copy link
Contributor Author

Mesbah-Alam commented Jan 31, 2023

Test on Win: Grinder_JCK/1057
Test on xLinux: Grinder_JCK/1059

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mesbah-Alam Mesbah-Alam changed the title Avoid using realpath for JCK_ROOT Avoid using realpath for tck root Jan 31, 2023
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongyuZhang LongyuZhang merged commit 570c53c into adoptium:master Feb 1, 2023
@Mesbah-Alam Mesbah-Alam deleted the fix-jck-win branch February 6, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants