Unexclude com/sun/jdi tests on windows for JDK8 #4288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are 2 tests, which were also excluded on linux-s390x. I kept them excluded on linux-s390x, as that is separate issue, just updated links to that other issue (windows issue -> s390x issue). |
smlambert
approved these changes
Feb 2, 2023
sendaoYan
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem with jdi tests on windows has been fixed by JDK-8295164 [1]. These tests are part of jdk/tier1 and are being ran as part of testing in GitHub CI on jdk8u-dev since. Also comment in referenced aqa-tests issue says, that tests can be removed from list, once that JDK issue is fixed.
Fixes #2415
[1] https://bugs.openjdk.org/browse/JDK-8295164
[2] #2415 (comment)