Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexclude gc/metaspace/TestCapacityUntilGCWrapAround.java on JDK8 #4292

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

zzambers
Copy link
Contributor

@zzambers zzambers commented Jan 31, 2023

Failure of gc/metaspace/TestCapacityUntilGCWrapAround.java on windows x86 has been fixed by JDK-8226236 backport:
openjdk/jdk8u-dev#192

@smlambert
Copy link
Contributor

@zzambers
Copy link
Contributor Author

zzambers commented Feb 2, 2023

@smlambert I think TARGET supposed to be hotspot_custom rather than jdk_custom

@smlambert
Copy link
Contributor

Yep thanks @zzambers, it was late and I was sleeping through the launch of these... relaunch here: https://ci.adoptopenjdk.net/view/Test_grinder/job/Grinder/6544

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia merged commit 16f593b into adoptium:master Feb 2, 2023
@zzambers
Copy link
Contributor Author

zzambers commented Feb 8, 2023

Note:
Was tested on win64 should have been win32. When testing other PR I have noticed that test is still failing on win32:
https://ci.adoptopenjdk.net/job/Grinder/6603/

When checked logs, current nightly build does not yet contain JDK-8226236:
SOURCE=".:git:444ca765c8cc+"
https://github.com/adoptium/jdk8u/tree/444ca765c8cc

Should get fixed in upcoming nightly build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants