Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support comma separated list of test flags #4298

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Support comma separated list of test flags #4298

merged 1 commit into from
Feb 2, 2023

Conversation

Mesbah-Alam
Copy link
Contributor

@Mesbah-Alam Mesbah-Alam commented Feb 1, 2023 •
edited
Loading

Resolves backlog/issues/1017
Signed-off-by: Mesbah Alam Mesbah_Alam@ca.ibm.com

@Mesbah-Alam
Support comma separated list of test flags
e9ba671 
Signed-off-by: Mesbah Alam <Mesbah_Alam@ca.ibm.com>
@Mesbah-Alam
Copy link
Contributor Author

Mesbah-Alam commented Feb 1, 2023 •
edited
Loading

  • Tests with TEST_FLAG=fips: Grinder/30843 (Green. Fips related exclude file is being picked up).
  • Test with no TEST_FLAG given: Grinder/30844 (Unstable - as expected, with org_ietf test + -Dsemeru.fips=true ).

@Mesbah-Alam Mesbah-Alam marked this pull request as ready for review February 1, 2023 18:44
llxia
llxia approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

karianna
karianna approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we want a proper logger

@Mesbah-Alam
Copy link
Contributor Author

@karianna - adding a proper logger to JavaTestRunner would be a nice to have! Will keep that in mind. Thanks!

@Mesbah-Alam Mesbah-Alam merged commit 8a527a5 into adoptium:master Feb 2, 2023
@Mesbah-Alam Mesbah-Alam deleted the update-testflag-val branch February 6, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@llxia llxia llxia approved these changes

@karianna karianna karianna approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mesbah-Alam @karianna @llxia