Implement MultiJVM tck in one node #4372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
a) Test this PR with single-node solution using
b) Test this PR with multi-node solution using AIX : Grinder_JCK/1123. |
Mesbah-Alam
force-pushed
the
impl-one-node-sol
branch
7 times, most recently
from
c5be279 to
451c7cb
Compare
Mesbah-Alam
force-pushed
the
impl-one-node-sol
branch
8 times, most recently
from
3809d54 to
c35c20d
Compare
llxia
reviewed
Mar 2, 2023
jck/jck.mk
Outdated
| else ifeq ($(ARCH),s390x) | ||
| USE_MULTINODE = true | ||
| endif | ||
| endif |
There was a problem hiding this comment.
We should be able to use $(SPEC). See https://github.com/adoptium/aqa-tests/blob/master/openjdk/openjdk.mk#L110 for example.
There was a problem hiding this comment.
That's simpler! Updated. Tested with AIX: Grinder_JCK/1125, xLinux: Grinder_JCK/1126.
Mesbah-Alam
force-pushed
the
impl-one-node-sol
branch
2 times, most recently
from
4956466 to
ec0807f
Compare
Signed-off-by: Mesbah Alam <Mesbah_Alam@ca.ibm.com>
Mesbah-Alam
force-pushed
the
impl-one-node-sol
branch
from
ec0807f to
75219ee
Compare
karianna
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements backlog/issues/1035
Signed-off-by: Mesbah Alam Mesbah_Alam@ca.ibm.com