-
-
Notifications
You must be signed in to change notification settings - Fork 317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logic to process platform specific exclude files #4486
Conversation
Mesbah-Alam
commented
Mar 29, 2023
•
edited
Loading
edited
- Pass in dev(common and platform specific) and fips exclude lists via customJtx.
- Use ${SPEC} to determine platform.
- Remove logic to process comma separated testflags.
- Clean up code.
- Related backlog/issues/1029
0615ff1
to
efbff2c
Compare
Test with sanity
|
Note: This PR can only be delivered after corresponding directory structure changes to all tck repo's have been made. |
e7c853b
to
3c3bb6d
Compare
3c3bb6d
to
d2abb05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d7dcf5d
to
c4365ba
Compare
Note, this branch has been rebased and following update has been made to the change added by #4506: Sanity check with one tck target on 17: Grinder/32286 (green). |
Suggesting: whenever it's safe to merge, please leave this PR to be merged by me; since its delivery needs to be coordinated with those of the related PRs for tck repo's (to make the corresponding changes to the repo's). Internal tck builds will break otherwise. |
Converted to Draft to prevent early merging |
Just for the record, we have decided to merge this PR after the release as the related repo structure is also needed to be updated to correspond to this change. Once the changes are made, it is not backward compatible. The changes only affect IBM. After the release,
|
4515918
to
a2ad93c
Compare
593f947
to
f356b3c
Compare
Signed-off-by: Mesbah Alam <Mesbah_Alam@ca.ibm.com>
Re: #4486 (comment)
|
Temurin-compliance /Grinder/3474/ |