Remove the variations from jdk_custom #4572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to adoptium#4495 (comment) The jdk_custom variations are not necessarily the desired variations to run. Since jdk_lang_j9 was added for Mode501 (-Xgcpolicy:balanced), this variation is arguably missing from jdk_custom. If you replace command line options, the variations may end up doing nothing except extra runs. Signed-off-by: Peter Shipton <Peter_Shipton@ca.ibm.com>
llxia
approved these changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to
#4495 (comment)
The jdk_custom variations are not necessarily the desired variations to run. Since jdk_lang_j9 was added for Mode501 (-Xgcpolicy:balanced), this variation is arguably missing from jdk_custom. If you replace command line options, the variations may end up doing nothing except extra runs.