Update pingPerf test replacing OpenLiberty base image #4609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
LongyuZhang
commented
Jun 7, 2023
LongyuZhang
commented
- Update pingPerf test replacing OpenLiberty base image
- Update pingPerf test replacing OpenLiberty base image Signed-off-by: LongyuZhang <longyu.zhang@ibm.com>
|
Test Links:
|
llxia
reviewed
Jun 8, 2023
| @@ -86,7 +86,8 @@ prepare() { | |||
| curCommitID=$(git rev-parse HEAD) | |||
| echo "Using dockerfile from OpenLiberty/ci.docker repo branch $openLibertyBranch with commit hash $curCommitID" | |||
| libertyDockerfilePath="releases/latest/beta/Dockerfile.ubi.openjdk17" | |||
| sed -i 's;FROM icr.io\/appcafe\/ibm-semeru-runtimes:open-17-ea-jdk-ubi-amd64;FROM local-ibm-semeru-runtimes:latest;' $libertyDockerfilePath | |||
| # replace OpenLiberty dockerfile base image | |||
| sed -i 's;FROM icr.io\/appcafe\/ibm-semeru-runtimes:open-17-jdk-ubi;FROM local-ibm-semeru-runtimes:latest;' $libertyDockerfilePath | |||
There was a problem hiding this comment.
In case the OpenLiberty changes this again, we can add a check? If the string that we are looking for does not exist, fail the build? For example:
imageFrom="FROM icr.io/appcafe/ibm-semeru-runtimes:open-17-jdk-ubi;"
grep "${imageFrom}" $libertyDockerfilePath
rtCode=$?
if [ $rtCode == 0 ]; then
echo "Replace ${imageFrom} to FROM local-ibm-semeru-runtimes:latest;"
sed -i 's;FROM icr.io\/appcafe\/ibm-semeru-runtimes:open-17-jdk-ubi;FROM local-ibm-semeru-runtimes:latest;' $libertyDockerfilePath
else
echo "Cannot find ${imageFrom} in https://github.com/OpenLiberty/ci.docker/blob/instanton/releases/latest/beta/Dockerfile.ubi.openjdk17"
exit 1
fi
There was a problem hiding this comment.
The above code will not work as we have space in imageFrom. Maybe we can use q command in sed:
https://stackoverflow.com/questions/15965073/return-value-of-sed-for-no-match/15965681#15965681
There was a problem hiding this comment.
We have decided to do this in a separate PR so the weekly run will fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.