Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update JavatestUtil to include fixes present in JavaTestRunner #4643

Conversation

adamfarley
Copy link
Contributor

@adamfarley adamfarley commented Jun 22, 2023

Most of these enhancements were added to similar code in this file's predecessor, JavaTestRunner.java.

Includes:

  • future-proofing against errors caused by new and unexpected jck version strings (e.g. jck17a).
  • centralisation of error messages
  • removing code duplication around security.properties file
  • formatting improvements for readability
  • and removal of code that added options only used by jdk 9 and 10, short-term releases that are no longer built at Adoptium.

Most of these enhancements were added to similar code in this file's
predecessor, JavaTestRunner.java.

Includes:
- future-proofing against errors caused by new and unexpected jck
version strings (e.g. jck17a).
- centralisation of error messages
- removing code duplication around security.properties file
- and formatting improvements for readability

Signed-off-by: Adam Farley <adfarley@redhat.com>
@adamfarley
Copy link
Contributor Author

adamfarley commented Jun 22, 2023

The key changes were tested here - All passed.

The full changes are being tested here - All passed.

Copy link
Contributor

@sendaoYan sendaoYan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@andrew-m-leonard andrew-m-leonard merged commit 165701f into adoptium:master Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants