Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom PLATFORM_DIR to be set #4879

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Allow custom PLATFORM_DIR to be set #4879

merged 1 commit into from
Nov 22, 2023

Conversation

llxia
Copy link
Contributor

@llxia llxia commented Nov 21, 2023

resolves: #4878

@llxia
Allow custom PLATFORM_DIR to be set
f244017 
resolves: adoptium#4878

Signed-off-by: Lan Xia <Lan_Xia@ca.ibm.com>
@llxia
Copy link
Contributor Author

llxia commented Nov 21, 2023

Test link1
Test link2

image

@llxia llxia marked this pull request as ready for review November 21, 2023 21:17
@llxia
Copy link
Contributor Author

llxia commented Nov 21, 2023

FYI @AdamBrousseau

LongyuZhang
LongyuZhang approved these changes Nov 21, 2023
View reviewed changes
Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karianna karianna merged commit 2ea383b into adoptium:master Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LongyuZhang LongyuZhang LongyuZhang approved these changes

@karianna karianna karianna approved these changes

@smlambert smlambert Awaiting requested review from smlambert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Collect_AQA_TAP job to allow custom folder names
3 participants
@llxia @karianna @LongyuZhang