Unset CUSTOMIZED_SDK_URL if SDK_RESOURCE is not customized

[sophia-guo]

CUSTOMIZED_SDK_URL is secondary parameter determined by primary parameter SDK_RESOURE. If SDK_RESOURCE is set as non-customized, CUSTOMIZED_SDK_URL should be set as none( except nightly)

Fix #2097

[smlambert]

Asking for a review from @llxia to check it works for the ways that this field may be overwritten to pickup nightly openj9 builds and when used as part of AQA_Test_Pipeline.

[sophia-guo]

I believe that nightly openj9 builds is in the category if (params.SDK_RESOURCE == 'nightly' && params.CUSTOMIZED_SDK_URL) , which won't be affected.

[llxia]

Here, we assume if user provides SDK_RESOURCE != 'customized' and CUSTOMIZED_SDK_URL, we will ignore CUSTOMIZED_SDK_URL value and proceed with SDK_RESOURCE value only.
IMO, we should just fail in this case.

I would like to rewrite the whole logic to be more readable:

if (params.CUSTOMIZED_SDK_URL) {
	if (params.SDK_RESOURCE == 'nightly') {
		// remove single quote to allow variables to be set in CUSTOMIZED_SDK_URL
        	CUSTOMIZED_SDK_URL_OPTION = "-c ${params.CUSTOMIZED_SDK_URL}"
	} else if (!params.SDK_RESOURCE || params.SDK_RESOURCE == 'customized') {
		SDK_RESOURCE = "customized"
		CUSTOMIZED_SDK_URL_OPTION = "-c '${params.CUSTOMIZED_SDK_URL}'"
                … // RI_JDK code
        } else {
		error("SDK_RESOURCE: ${params.SDK_RESOURCE} and CUSTOMIZED_SDK_URL: ${params.CUSTOMIZED_SDK_URL} combo is not supported!)
        }
} else {
        if (params.SDK_RESOURCE == 'customized') {
		error("SDK_RESOURCE: ${params.SDK_RESOURCE}, please provide CUSTOMIZED_SDK_URL")
        }
}

[sophia-guo]

This is a more strict user story. Updated.

[llxia]

Thanks @sophia-guo . Could you run some Grinder to verify?

[sophia-guo]

https://ci.adoptium.net/view/Test_grinder/job/Grinder/8722/
https://ci.adoptium.net/view/Test_grinder/job/Grinder/8723/
https://ci.adoptium.net/view/Test_grinder/job/Grinder/8725/

[llxia]

Thanks @sophia-guo .
I have also tested the case of the SDK_RESOURCE=nightly and CUSTOMIZED_SDK_URL for openj9 (internal link)