Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jtreg duplicated ssl call #5136

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

judovana
Copy link
Contributor

@judovana judovana commented Mar 12, 2024

@judovana judovana force-pushed the removeJtregDuplicatedSslCall branch from 6b61167 to dc6e1cb Compare March 12, 2024 14:01
@judovana judovana force-pushed the removeJtregDuplicatedSslCall branch from dc6e1cb to bb61f83 Compare March 12, 2024 14:05
@judovana
Copy link
Contributor Author

Copy link
Contributor

@smlambert smlambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as from the churn review, #5134 (review)

@judovana judovana force-pushed the removeJtregDuplicatedSslCall branch from 55aec90 to b36420a Compare March 15, 2024 09:17
@judovana judovana force-pushed the removeJtregDuplicatedSslCall branch from b36420a to b96fe01 Compare March 15, 2024 09:19
@judovana
Copy link
Contributor Author

Returned back to aqavit jtreg runner:
https://ci.adoptium.net/view/Test_grinder/job/Grinder/9159
there is failure javax.net.ssl.SSLHandshakeException: The client supported protocol versions [(D)TLS-127.23, TLSv1.2, TLSv1.1, TLSv1] are not accepted by server preferences [TLS13] which do not look like casued by jtreg launcher... Reruning one more times.

@judovana
Copy link
Contributor Author

judovana commented Mar 15, 2024

@smlambert smlambert merged commit 9e721cd into adoptium:master Mar 15, 2024
2 checks passed
@pshipton
Copy link
Contributor

This seems the cause of eclipse-openj9/openj9#19164 (comment), similarly to #5134 (comment)

@pshipton
Copy link
Contributor

Excluded the test on OpenJ9 amac via #5153

sophiaxu0424 pushed a commit to sophiaxu0424/aqa-tests that referenced this pull request Mar 19, 2024
* Remove jtreg duplicated ssl call

* Removed build's download of jtreg as suite pulls its own

* Returned back to aqavit's jtregs withotu downloading custom one

Which will make
openjdk/jtreg@8c105f2
missing again, but that - a tleast for jdk bigger then 8, should be eg
from https://ci.adoptium.net/job/dependency_pipeline/lastSuccessfulBuild/artifact/jtreg/jtregtip.tar.gz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants