Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow OpenJCEPlus test execution with Java 11 #5164

Conversation

jasonkatonica
Copy link
Contributor

Java 11 now includes the OpenJCEPlus module and should be tested accordingly similar to other Java releases.

Java 11 now includes the OpenJCEPlus module and should be tested
accordingly similar to other Java releases.
@llxia
Copy link
Contributor

llxia commented Mar 21, 2024

Waiting for the issue in oe to be fixed or test framework support for differentiating ce vs oe.

@llxia
Copy link
Contributor

llxia commented Mar 21, 2024

Thanks @AdamBrousseau . The issue in oe is fixed.

Copy link
Contributor

@llxia llxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@llxia llxia requested a review from LongyuZhang March 21, 2024 14:42
@llxia
Copy link
Contributor

llxia commented Mar 21, 2024

Just for the record, the change needs to backport into the AQA release branch https://github.com/adoptium/aqa-tests/tree/v1.0.1-release, so that the tests can run against the milestone and April release builds.

Copy link
Contributor

@LongyuZhang LongyuZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LongyuZhang LongyuZhang merged commit ea10530 into adoptium:master Mar 21, 2024
2 checks passed
LongyuZhang pushed a commit to LongyuZhang/aqa-tests that referenced this pull request Mar 21, 2024
Java 11 now includes the OpenJCEPlus module and should be tested
accordingly similar to other Java releases.
@jasonkatonica jasonkatonica deleted the katonica/feature/support11openjceplus branch March 21, 2024 17:03
@jasonkatonica jasonkatonica restored the katonica/feature/support11openjceplus branch March 21, 2024 17:04
@jasonkatonica
Copy link
Contributor Author

This update was ported to the v1.0.1-release branch using PR 5198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants