Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move NUM_LIST to the outermost scope that includes a reference #5518

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Move NUM_LIST to the outermost scope that includes a reference #5518

merged 1 commit into from
Aug 21, 2024

Conversation

keithc-ca
Copy link
Contributor

@keithc-ca
Move NUM_LIST to the outermost scope that includes a reference
1aad3fa 
Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
@pshipton
Copy link
Contributor

Trying to run testing is failing with Exception: groovy.lang.MissingPropertyException: No such property: NUM_LIST for class: groovy.lang.Binding. I expect it will continue to do so until this or another fix is merged.

@pshipton pshipton requested review from JasonFengJ9 and llxia August 20, 2024 22:09
@JasonFengJ9
Copy link
Contributor

Verification run - https://openj9-jenkins.osuosl.org/job/Grinder/3769/console
It looks good.

@JasonFengJ9 JasonFengJ9 merged commit 0aeebf6 into adoptium:master Aug 21, 2024
2 checks passed
@llxia
Copy link
Contributor

llxia commented Aug 21, 2024

This needs to be backported into https://github.com/adoptium/aqa-tests/tree/v1.0.3-release as the original problematic PR is in the v1.0.3 branch: #5517

llxia pushed a commit to llxia/aqa-tests that referenced this pull request Aug 21, 2024
@keithc-ca @llxia
Move NUM_LIST to the outermost scope that includes a reference (adopt…
cb2441a 
…ium#5518)

Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
@llxia llxia mentioned this pull request Aug 21, 2024
Merged
@llxia
Copy link
Contributor

llxia commented Aug 21, 2024

back port: #5519

@keithc-ca keithc-ca deleted the num_list branch August 21, 2024 12:57
JasonFengJ9 pushed a commit that referenced this pull request Aug 21, 2024
@llxia @keithc-ca
Move NUM_LIST to the outermost scope that includes a reference (#5518) (
d4131a2 
#5519)

Signed-off-by: Keith W. Campbell <keithc@ca.ibm.com>
Co-authored-by: Keith W. Campbell <keithc@ca.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshipton pshipton pshipton approved these changes

@JasonFengJ9 JasonFengJ9 JasonFengJ9 approved these changes

@llxia llxia Awaiting requested review from llxia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@keithc-ca @pshipton @JasonFengJ9 @llxia