Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github linter failure due to methods count in build base file being 31 #925

Closed
sxa opened this issue Feb 13, 2024 · 2 comments
Closed

Github linter failure due to methods count in build base file being 31 #925

sxa opened this issue Feb 13, 2024 · 2 comments
Assignees
@sophia-guo

Comments

@sxa
Copy link
Member

sxa commented Feb 13, 2024 

          The linter warning is the methods is 31, the default maxMethods=30 https://codenarc.org/codenarc-rules-size.html#methodcount-rule

Originally posted by @sophia-guo in #923 (comment)
@karianna
Copy link
Contributor

Should that shell script really have more than 30 methods? Probably not...

@sophia-guo sophia-guo self-assigned this Feb 16, 2024
@sophia-guo
Copy link
Contributor

Fixed by #931 https://github.com/adoptium/ci-jenkins-pipelines/blob/master/pipelines/build/common/build_base_file.groovy#L15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sophia-guo sophia-guo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@karianna @sxa @sophia-guo