-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger the release dry run right after each jdk build is done #923
Conversation
Thank you for creating a pull request!Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work). Code Quality and Contributing GuidelinesIf you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before. TestsGithub actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation. In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post |
81fca4f
to
77c1795
Compare
The linter warning is the methods is 31, the default maxMethods=30 https://codenarc.org/codenarc-rules-size.html#methodcount-rule |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though noting a minor typo in comment
Eventually I could see dryrunReleasePublish(IndividualBuildConfig config) becoming publishRelease(IndividualBuildConfig config, BooleanParameterValue dryRun)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I understand it this will happen as part of the top level openjdkXX-pipeline which sounds good to me!
Co-authored-by: Shelley Lambert <slambert@gmail.com>
Correct. Start the dry run from the top level openjdkXX-pipeline |
I didn't spot this at first but it looks like this failed the github linter check - possibly as a result of it going over the linter's limit for the number of methods in a class with new ones being added here:
I can't see anything else that was flagged in there, but this will presumably cause subsequent PRs to the pipelines to fail the checks too. |
Yeah but we need to decide what to do with it since at the moment it's going to cause check failures which we don't want - either we need to reduce the number of methods or adjust the linter configuration to avoid problems for contributors. I'll raise an issue. |
Trigger the release dry run right after each jdk build is done
Provide the release publish build link per os, arch with pre-filled parameters
Close #911