Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable tests during April release week #135

Merged
merged 1 commit into from
Apr 19, 2021

Conversation

andrew-m-leonard
Copy link
Contributor

Signed-off-by: Andrew Leonard anleonar@redhat.com

Signed-off-by: Andrew Leonard <anleonar@redhat.com>
@andrew-m-leonard
Copy link
Contributor Author

run tests

@github-actions
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), I require an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.

@andrew-m-leonard
Copy link
Contributor Author

Request TSC approval

@M-Davies M-Davies added this to the April 2021 milestone Apr 19, 2021
@sxa
Copy link
Member

sxa commented Apr 19, 2021

I got thrown by the fact this didn't change the value in config_regeneration.groovy as we have in previous cycles but it looks like #102 likely removed the need for that so it should be ok 👍🏻

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eclipse-temurin-bot
Copy link
Collaborator

🟢 PR TESTER RESULT 🟢

✅ All pipelines passed! ✅

@gdams gdams merged commit 9425e73 into adoptium:master Apr 19, 2021
@sophia-guo
Copy link
Contributor

sophia-guo commented Apr 19, 2021

I believe if we still need to manually trigger regenerating build jobs otherwise this change won't work.

By regenerating jobs I mean:
https://ci.adoptopenjdk.net/job/build-scripts/job/utils/job/pipeline_jobs_generator_jdk/
https://ci.adoptopenjdk.net/job/build-scripts/job/utils/job/pipeline_jobs_generator_jdk8u/
https://ci.adoptopenjdk.net/job/build-scripts/job/utils/job/pipeline_jobs_generator_jdk11u/
https://ci.adoptopenjdk.net/job/build-scripts/job/utils/job/pipeline_jobs_generator_jdk16u/

I can do that if no other concerns. Just a heads-up.

AdamBrousseau added a commit to AdamBrousseau/ci-jenkins-pipelines that referenced this pull request Apr 23, 2021
sxa added a commit to sxa/ci-jenkins-pipelines that referenced this pull request Apr 23, 2021
sxa added a commit that referenced this pull request Apr 27, 2021
AdamBrousseau pushed a commit to AdamBrousseau/ci-jenkins-pipelines that referenced this pull request Jun 25, 2021
AdamBrousseau added a commit to AdamBrousseau/ci-jenkins-pipelines that referenced this pull request Jun 25, 2021
llxia pushed a commit to llxia/ci-jenkins-pipelines that referenced this pull request Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants