Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable sanity.external test for jdk8/17/19/head on x64linux #412

Closed
wants to merge 1 commit into from

Conversation

zdtsw
Copy link
Contributor

@zdtsw zdtsw commented Sep 15, 2022

- jdk11 has been enabled already
- set full tests to overwrite "default"
- skip 18 since we wont have more release on it

Fix: #273

	- jdk11 has been enabled
	- set full tests to overwrite "default"
	- skip 18 since we wont have more release on it
@github-actions
Copy link

Thank you for creating a pull request!

Please check out the information below if you have not made a pull request here before (or if you need a reminder how things work).

Code Quality and Contributing Guidelines

If you have not done so already, please familiarise yourself with our Contributing Guidelines and Code Of Conduct, even if you have contributed before.

Tests

Github actions will run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

In order to run the advanced pipeline tests (executing a set of mock pipelines), it requires an admin to post run tests on this PR.
If you are not an admin, please ask for one's attention in #infrastructure on Slack or ping one here.
To run full set of tests, use "run tests"; a subset of tests on specific jdk version, use "run tests quick 11,18"

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but would prefer @smlambert to approve

@smlambert
Copy link
Contributor

Not ready to merge this yet, some things we need to check first:

  • the health of the sanity.external target in a Grinder
  • the availability/number of machines with the sw.tool.docker tag

@zdtsw zdtsw changed the title feat: enable sanity.external test for jdk8/17/19/head feat: enable sanity.external test for jdk8/17/19/head on x64linux Dec 20, 2022
@zdtsw
Copy link
Contributor Author

zdtsw commented Feb 21, 2024

close it as stale PR

@zdtsw zdtsw closed this Feb 21, 2024
@github-actions github-actions bot added linux x64 Issues that affect or relate to the x64/x32 LINUX OS labels Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jenkins-pipeline linux testing x64 Issues that affect or relate to the x64/x32 LINUX OS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable weekly sanity.external testing on other versions besides jdk11
3 participants