Initial cut of Docs #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdams
approved these changes
Sep 22, 2021
timja
reviewed
Sep 22, 2021
sxa
reviewed
Sep 22, 2021
There was a problem hiding this comment.
Do we have any sort of overview of what the two scripts update_all.sh and perhaps also the manifest update one do? Ideally we need something like "The scripts checks for X,Y,Z and updates A,B,C". This is useful to know when the process needs to be run.
Might also be useful to flesh out the "diff output created" could be fleshed out - is that just a normal review of what's in the PR?
|
ECA check fails on anonymous gdams change |
tellison
reviewed
Sep 29, 2021
tellison
reviewed
Sep 29, 2021
sxa
requested changes
Sep 29, 2021
sxa
approved these changes
Sep 29, 2021
Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.