-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial cut of Docs #67
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have any sort of overview of what the two scripts update_all.sh
and perhaps also the manifest update one do? Ideally we need something like "The scripts checks for X,Y,Z and updates A,B,C". This is useful to know when the process needs to be run.
Might also be useful to flesh out the "diff output created" could be fleshed out - is that just a normal review of what's in the PR?
ECA check fails on anonymous gdams change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but the ECA check failure should be addressed prior to merging
Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>
No description provided.