-
-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: Add centos7 to dockerstatic dockerfiles #3402
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't realise we didn't already have one of these so yeah if it is suitable for passing the tests I'm ok with adding it for a few months :-)
Its git version is quite old
Causing problems with tests https://ci.adoptium.net/job/Test_openjdk17_hs_sanity.functional_x86-64_linux/405/console
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect this will need the changes made here to update the eol centos7 repositories.. see this PR: https://github.com/adoptium/infrastructure/pull/3647/files
RUN sed -i -e 's!mirrorlist!#mirrorlist!g' /etc/yum.repos.d/CentOS-Base.repo
RUN if [ "$(uname -m)" = "aarch64" ]; then \
echo "Running on arm64 architecture"; \
sed -i 's|#baseurl=http://mirror.centos.org/altarch/\$releasever/|baseurl=http://vault.centos.org/altarch/7.9.2009/|' /etc/yum.repos.d/CentOS-Base.repo; \
elif [ "$(uname -m)" = "ppc64le" ]; then \
echo "Running on ppc64le architecture"; \
sed -i 's|#baseurl=http://mirror.centos.org/altarch/\$releasever/|baseurl=http://vault.centos.org/altarch/7.9.2009/|' /etc/yum.repos.d/CentOS-Base.repo; \
else \
# Default To x64; \
echo "Running on another architecture"; \
sed -i -e 's!#baseurl=http://mirror.centos.org/centos/\$releasever!baseurl=https://vault.centos.org/7.9.2009/!g' /etc/yum.repos.d/CentOS-Base.repo; \
fi
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok.
Dont merge yet. I am adding steps to install git 2.15.0 form source since the latest git that can be installed on centos7 is 1.8 which is too old to run tests |
Security support for centos7 ends in June of this year, so its worth having a few containers on our machines until then
https://endoflife.date/centos