Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker: Fix Use Of mirrorlist.centos.org in dockerfiles for arm64 & ppc64le #3647

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Docker: Fix Use Of mirrorlist.centos.org in dockerfiles for arm64 & ppc64le #3647

merged 3 commits into from
Jul 3, 2024

Conversation

steelhead31
Copy link
Contributor

Fixes #3646

Update various calls to mirrorlist.centos.org with vault.centos.org, now that mirrorlist has been deprecated following the EOL of Centos 7.

Checklist

@steelhead31
Copy link
Contributor Author

steelhead31 commented Jul 2, 2024 •
edited
Loading

Tested on x64 & arm64 & ppc64le OK.

andrew-m-leonard
andrew-m-leonard approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

sxa
sxa reviewed Jul 2, 2024
View reviewed changes
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question ...
I guess the echo could be retained too but saying "Running from CentOS altarch repos" but I'd be tempted to just miss it out.

ansible/docker/Dockerfile.CentOS7 Outdated Show resolved Hide resolved
@steelhead31 steelhead31 requested a review from sxa July 2, 2024 14:27
sxa
sxa approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You can take or leave my suggestion on the message (It won't be obvious what "another" if you're just watching the output from building the dockerfile)

ansible/docker/Dockerfile.CentOS7 Outdated Show resolved Hide resolved
@karianna @sxa
Update ansible/docker/Dockerfile.CentOS7
c45bfba 
Co-authored-by: Stewart X Addison <6487691+sxa@users.noreply.github.com>
@karianna karianna merged commit ecf727d into adoptium:master Jul 3, 2024
9 checks passed
@steelhead31 steelhead31 deleted the fix_centos7_mirrors branch July 3, 2024 07:40
@richardlau richardlau mentioned this pull request Jul 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-m-leonard andrew-m-leonard andrew-m-leonard approved these changes

@sxa sxa sxa approved these changes

@karianna karianna karianna approved these changes

Assignees
No one assigned
Labels
arch:arm64 arch:ppc64le (pLinux) docker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Centos7 Docker Image, Mirrors failing for arm64 & ppc64le
4 participants
@steelhead31 @karianna @sxa @andrew-m-leonard