Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible: Install shared-mime-info on Centos UBI RHEL and Fedora #3661

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

Haroon-Khel
Copy link
Contributor

@Haroon-Khel Haroon-Khel commented Jul 5, 2024

  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

ref #3614 (comment) shared-mime-info is needed for java/nio/file/Files/probeContentType/Basic.java to pass

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you run this through VPC before we approve please?

@Haroon-Khel
Copy link
Contributor Author

VPC running on Centos6 7 and 8

https://ci.adoptium.net/view/Tooling/job/VagrantPlaybookCheck/1908/console

@sxa
Copy link
Member

sxa commented Jul 8, 2024

VPC running on Centos6 7 and 8

https://ci.adoptium.net/view/Tooling/job/VagrantPlaybookCheck/1908/console

Not Fedora?

@Haroon-Khel
Copy link
Contributor Author

Not Fedora?

I must have missed it https://ci.adoptium.net/view/Tooling/job/VagrantPlaybookCheck/1909/

On that note, F35 is EOL. I've created #3662 to have it upgraded

@Haroon-Khel
Copy link
Contributor Author

Haroon-Khel commented Jul 9, 2024

The playbooks ran fine in each of the vpc except for centos6 https://ci.adoptium.net/job/VagrantPlaybookCheck/OS=CentOS6,label=vagrant/1908/console but the failure is not related to the playbook execution. The vagrant vm did not boot

@Haroon-Khel Haroon-Khel requested a review from sxa July 9, 2024 12:41
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Haroon-Khel Haroon-Khel merged commit e9cd338 into adoptium:master Jul 10, 2024
18 checks passed
@Haroon-Khel Haroon-Khel deleted the ubi.sharedmimeinfo branch July 10, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants