Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker: Include checksum validation for Cygwin & Ansible Downloads #3730

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

steelhead31
Copy link
Contributor

@steelhead31 steelhead31 commented Sep 11, 2024

Fixes #3715

Checklist

VPC Successful: https://ci.adoptium.net/job/VagrantPlaybookCheck/1960/OS=Win2022,label=vagrant/console

@steelhead31 steelhead31 marked this pull request as ready for review September 11, 2024 12:28
@steelhead31 steelhead31 requested a review from sxa September 11, 2024 13:23
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing at https://ci.adoptium.net/job/win2022_docker_image_updater/label=dockerhost-azure-win2022-x64-1/9/console although I'm a bit unclear as to why it's showing changes even in the first few lines - has this commit changed the line endings on the file?

@steelhead31
Copy link
Contributor Author

Testing at https://ci.adoptium.net/job/win2022_docker_image_updater/label=dockerhost-azure-win2022-x64-1/9/console although I'm a bit unclear as to why it's showing changes even in the first few lines - has this commit changed the line endings on the file?

Yup, It had been switched to unix line endings, rather than windows, should be sorted now.

@steelhead31 steelhead31 requested a review from sxa September 12, 2024 12:49
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@steelhead31 steelhead31 merged commit 617431d into adoptium:master Sep 13, 2024
11 checks passed
@steelhead31 steelhead31 deleted the fix_issue_3715 branch September 13, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

windocker: Perform checksum verification on the cygwin + WinRM setup downloads
3 participants