Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 3577 #3732

Merged
merged 7 commits into from
Sep 20, 2024
Merged

Fix issue 3577 #3732

merged 7 commits into from
Sep 20, 2024

Conversation

steelhead31
Copy link
Contributor

Fixes #3577

Adds Ubuntu 24.04 support to the Vagrant playbook check process.

Required changes to compiling NASM on Ubuntu 24.04
Also a change to the VPC build tests to build using the devkit, rather than gcc 7.5.

Checklist

@steelhead31
Copy link
Contributor Author

steelhead31 commented Sep 16, 2024 •
edited
Loading

✔️ VPC / Ubuntu 24 / JDK21 / https://ci.adoptium.net/job/SFR-VPC-AZURE-POC/OS=Ubuntu2404,label=vagrant/72/
✔️ VPC / Ubuntu 24 / JDK17 https://ci.adoptium.net/job/SFR-VPC-AZURE-POC/OS=Ubuntu2404,label=vagrant/73/

@steelhead31 steelhead31 marked this pull request as ready for review September 17, 2024 08:45
sxa
sxa previously requested changes Sep 17, 2024
View reviewed changes
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One line comment fix :-)

What is the history of the nasm patch? I was initally concerned about provenance / SBoM content but nasm is only used for OpenJ9 AFAIK. Is there a newer version of nasm that has the fix needed here? I guess our other option would be to skip it on Ubuntu 24.04 ...

ansible/pbTestScripts/buildJDK.sh Outdated Show resolved Hide resolved
@steelhead31
Copy link
Contributor Author

One line comment fix :-)

What is the history of the nasm patch? I was initally concerned about provenance / SBoM content but nasm is only used for OpenJ9 AFAIK. Is there a newer version of nasm that has the fix needed here? I guess our other option would be to skip it on Ubuntu 24.04 ...

It's from NASM themselves, its in later versions of NASM.. netwide-assembler/nasm@5eb1838 & netwide-assembler/nasm@53371dd   .. Im happy to skip on Ubuntu 24 if you'd rather? .. It is fixed in later versions though.

@steelhead31
Copy link
Contributor Author

Bug fix for nasm: https://bugzilla.nasm.us/show_bug.cgi?id=3392461

@steelhead31 steelhead31 requested a review from sxa September 17, 2024 14:26
@sxa
Copy link
Member

sxa commented Sep 17, 2024

It is fixed in later versions though.

The real question is whether it's worth upgrading nasm. @pshipton @AdamBrousseau Any thoughts on this? Let's hold off until we hear back on this.

@pshipton
Copy link
Contributor

OpenJ9 isn't planning to build on Ubuntu 24_04, although I suppose a developer might want to, as long as they don't want to run the resulting JVM elsewhere. I don't see an issue installing a newer nasm version on this platform. The OpenJ9 build instructions specify v2.13.03 or newer. There are some other OpenJ9 issues trying to compile on 24_04 atm, although they should be fixed within the next week or so.
eclipse-openj9/openj9#20170
eclipse-openj9/openj9#20171

@steelhead31
Copy link
Contributor Author

OpenJ9 isn't planning to build on Ubuntu 24_04, although I suppose a developer might want to, as long as they don't want to run the resulting JVM elsewhere. I don't see an issue installing a newer nasm version on this platform. The OpenJ9 build instructions specify v2.13.03 or newer. There are some other OpenJ9 issues trying to compile on 24_04 atm, although they should be fixed within the next week or so. eclipse-openj9/openj9#20170 eclipse-openj9/openj9#20171

Thanks @pshipton , I'll bump NASM to the current stable release 2.16.03 :)

@sxa sxa dismissed their stale review September 17, 2024 15:27

Will be unavailable for the next 3 days and we have an alternate solution that will be impemented in this PR

@steelhead31 @karianna @sxa
VPC: Bump NASM to v2.16.03 and abstract
b4ade61 
Linter Fix

Linter fix

VPC: Fix whitespace

VPC: Bump NASM to 2.16.03

This removes the need for a patch to support gcc > 7.5

Co-Authored-By: Martijn Verburg <martijnverburg@gmail.com>
Co-Authored-By: Stewart X Addison <6487691+sxa@users.noreply.github.com>
@steelhead31 steelhead31 merged commit a39cca2 into adoptium:master Sep 20, 2024
11 of 12 checks passed
@steelhead31 steelhead31 deleted the fix_issue_3577 branch September 20, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haroon-Khel Haroon-Khel Haroon-Khel approved these changes

@karianna karianna karianna approved these changes

@sxa sxa Awaiting requested review from sxa

Assignees
No one assigned
Labels
ansible pbTests Vagrant
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Ubuntu 24.04 to Vagrant Playbook Check Job
5 participants
@steelhead31 @sxa @pshipton @karianna @Haroon-Khel