-
-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MSI: RegKey "CurrentVersion" is not set on latest Adoptium JDK8 build #329
Comments
@douph1 Do you have a comment on this issue? We likely need to respin the MSI's again. |
This condition is here to overide the reg key only if the new major version from the running installer is greater than the previous one installed.
is read from the regritry.
But, we can't compare numericaly 1.8 and 11, we test first if JAVASOFT_CURRENTVERSION <> "1.8" then compare 11 vs 16 for exemple. |
See linked PR #341 for the fix, you can test the artefact build via github action. |
@douph1 I'm not convinced this is fixed. It still seems that with my latest msi installer the |
@douph1 @karianna |
To reproduce
JavaSoft (Oracle) Registry Keys
Observed behaviour
HKEY_LOCAL_MACHINE/SOFTWARE/JavaSoft/Java Development Kit
CurrentVersion=1.8
Expected behaviour
Screenshots
Suspected change
e178aef
#307
#300
I don't quite understand this condition
Says if current version (installed) is 1.8 and current version is less than major version we're building (8), then set CurrentVersion. So it should work? Not sure why it doesn't or why that condition is there. But, this is a bit beyond me.
If I change it to the following, it works
But If I install one with the patch, with no previous install, I don't get the reg values. So I'm not sure what's going on.
The text was updated successfully, but these errors were encountered: