Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Docker 20.10+ is required to build #491

Merged
merged 2 commits into from
Aug 30, 2022

Conversation

luozhenyu
Copy link
Contributor

Changes

  1. Docker 20.10+ is required to build.
    1. Because the --mount option is used without specify experimental dockerfile #syntax directive. https://github.com/adoptium/installer/blob/master/linux/jdk/redhat/src/main/packaging/Dockerfile#L27

    https://docs.docker.com/engine/release-notes/#20100
    buildkit,dockerfile: Support for RUN --mount options without needing to specify experimental dockerfile #syntax directive. dockerfile: update run mounts to stable channel moby/buildkit#1717

  2. Remove COMPOSE_DOCKER_CLI_BUILD
    1. Because docker compose is not used.
    2. Because COMPOSE_DOCKER_CLI_BUILD=1 is the default setting. https://docs.docker.com/compose/reference/envvars/#compose_docker_cli_build

@zdtsw
Copy link
Contributor

zdtsw commented Jun 27, 2022

Sure I agree we should remove unnecessary flag in our code to not cause confusion COMPOSE_DOCKER_CLI_BUILD

As for specify mini docker version, I am not aware of anyone doing local package build.
But if this caused any difficulties, we can definitely have that as a requirement in README

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karianna karianna requested a review from sxa June 27, 2022 11:52
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - although mostly for the link syntax fixes :-)

@gdams gdams merged commit 473d5d4 into adoptium:master Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants