Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 3 new parameters for branch #41

Merged
merged 2 commits into from
Oct 1, 2022
Merged

feat: add 3 new parameters for branch #41

merged 2 commits into from
Oct 1, 2022

Conversation

zdtsw
Copy link
Contributor

@zdtsw zdtsw commented Sep 30, 2022

Ref issue: adoptium/temurin-build#3103

in order to pass tag/SHA1 for 3 build related repo:s, to generate buildConfig from openjdk pipeline to downstream job. similar handler as for scm_ref and aqa_ref
- build_ref for temurin-build branch/tag/SHA1
- ci_ref for ci-jenkins-pipeline branch/tag/SHA1
- helper_ref for jenkins-helper branch/tag/SHA1

This PR depends on adoptium/ci-jenkins-pipelines#421

	- build_ref for temurin-build branch/tag
	- ci_ref for ci-jenkins-pipeline branch/tag
	- helper_ref for jenkins-helper branch/tag
@zdtsw zdtsw requested a review from karianna September 30, 2022 09:24
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to add comments / docs as to their usage

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set to comment vs Approve

@karianna karianna merged commit 9fd0637 into master Oct 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants