Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the default value of aqa-systemtestsRepo #105

Closed
sophia-guo opened this issue Oct 6, 2021 · 1 comment · Fixed by #108
Closed

Remove the default value of aqa-systemtestsRepo #105

sophia-guo opened this issue Oct 6, 2021 · 1 comment · Fixed by #108
Assignees
Labels
good first issue Good for newcomers

Comments

@sophia-guo
Copy link
Contributor

The default value of aqa-systemtestsRepo is set in aqa-tests/system/common.xml. It is unnecessary to reset it. That is we can deleted this line: https://github.com/adoptium/run-aqa/blob/master/action.yml#L26

With the default value of aqa-systemtestsRepo removed it would be better to call function getAqaSystemTestsRepo() only if aqa-systemtestsRepo is not empty and hence function getAqaSystemTestsRepo() do not need to care about the default value.

That is move the function call inside a if check block https://github.com/adoptium/run-aqa/blob/master/src/runaqa.ts#L63

 if (aqa-systemtestsRepo && aqa-systemtestsRepo.length !== 0) {
       getAqaSystemTestsRepo(aqasystemtestsRepo)
}

Hence

function getAqaSystemTestsRepo(aqasystemtestsRepo: string) {
  const repoBranch = parseRepoBranch(aqasystemtestsRepo)
  process.env.ADOPTOPENJDK_SYSTEMTEST_REPO = repoBranch[0];
  process.env.ADOPTOPENJDK_SYSTEMTEST_BRANCH = repoBranch[1];
}

@sophia-guo sophia-guo added the good first issue Good for newcomers label Oct 6, 2021
@Aaradhyaa717
Copy link
Contributor

Hi, I would like to work on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants