Added custom system tests repo and branch input option #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophia-guo
reviewed
Oct 1, 2021
src/runaqa.ts
Outdated
| @@ -57,6 +58,9 @@ export async function runaqaTest( | |||
| await exec.exec( | |||
| `${sevenzexe} e ${dependents} -o${process.env.GITHUB_WORKSPACE}/aqa-tests/TKG/lib` | |||
| ) | |||
| if(buildList.includes('system') || buildList.includes('openjdk')) { | |||
There was a problem hiding this comment.
openjdk tests is a different category from system. So we can just move this function call getAqaSystemTestsRepo to the following block https://github.com/adoptium/run-aqa/pull/102/files#diff-22673e27ee79038a5688a185a2cd7775b8d2a63bfb6c4b449d1d5195cc272faaR65
if (buildList.includes('system')) {
sophia-guo
reviewed
Oct 1, 2021
src/runaqa.ts
Outdated
| if (aqasystemtestsRepo.length !== 0) { | ||
| repoBranch = parseRepoBranch(aqasystemtestsRepo) | ||
| } | ||
| await exec.exec( |
There was a problem hiding this comment.
For Aqasystemtest the only thing we need is to export the repo and branch.
process.env.ADOPTOPENJDK_SYSTEMTEST_REPO = repoBranch[0]
process.env.ADOPTOPENJDK_SYSTEMTEST_BRANCH = repoBranch[1]
|
Waiting for checks to complete... |
smlambert
approved these changes
Oct 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #93