Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix macos aarch64 builds #2713

Merged
merged 1 commit into from
Sep 13, 2021
Merged

fix macos aarch64 builds #2713

merged 1 commit into from
Sep 13, 2021

Conversation

gdams
Copy link
Member

@gdams gdams commented Sep 13, 2021 •
edited
Loading

This was broken when the architecture was renamed from arm64 to aarch64 in adoptium/ci-jenkins-pipelines#147

Fixes: #1922

@github-actions
Copy link

Thank you for creating a pull request!
If you have not done so already, please familiarise yourself with our Contributing Guidelines and FAQ, even if you have contributed to the Adoptium project before. GitHub actions will now run a set of jobs against your PR that will lint and unit test your changes. Keep an eye out for the results from these on the latest commit you submitted. For more information, please see our testing documentation.

@github-actions github-actions bot added the macos Issues that affect or relate to the MAC OS label Sep 13, 2021
karianna
karianna approved these changes Sep 13, 2021
View reviewed changes
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added aarch Issues that affect or relate to the aarch ARCHITECTURE arm Issues that affect or relate to the ARM OS labels Sep 13, 2021
@gdams gdams merged commit 2cc5b7c into adoptium:master Sep 13, 2021
@karianna
Copy link
Contributor

PMC approved for release week as this platform was failing.

@gdams gdams deleted the mac_aarch64 branch September 13, 2021 13:30
@github-actions github-actions bot added the jenkins Issues that enhance or fix our jenkins server label Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sxa sxa sxa approved these changes

@karianna karianna karianna approved these changes

Assignees
No one assigned
Labels
aarch Issues that affect or relate to the aarch ARCHITECTURE arm Issues that affect or relate to the ARM OS jenkins Issues that enhance or fix our jenkins server macos Issues that affect or relate to the MAC OS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide native builds for ARM based Macs
3 participants
@gdams @karianna @sxa