aix: use fullpath for (g)make so PATH does not need to be modified #3441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.
If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.
If the code freeze is over you can remove this block by commenting /thaw.
karianna
approved these changes
Jul 21, 2023
|
Is the freeze over? |
gdams
approved these changes
Jul 28, 2023
|
/thaw |
github-actions
bot
dismissed
their stale review
Pull Request unblocked - code freeze is over.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
at system level.
See issue: adoptium/infrastructure#1544
The playbooks have prefixed system level PATH with /opt/freeware/bin. As that contains coreutils certain AIX commands that coreutils has repeatedly denied to add an AIX argument (noteablu
-p) this setting breaks many AIX management commands - even standard boot (ie, called from rcboot) scripts.In the issue noted above it is stated that this is needed so that
gmakeis found.This PR points the config at the actual binary
/opt/freeware/bin/make_64rather than depend on PATH and symbolic links to call the application.