Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Browse foreign values has a white BG #51

Closed
williamdes opened this issue Jul 14, 2023 · 4 comments · Fixed by #52
Closed

Browse foreign values has a white BG #51

williamdes opened this issue Jul 14, 2023 · 4 comments · Fixed by #52
Assignees
@adorade
Labels
bug Something isn't working

Comments

@williamdes
Copy link

Describe the bug

image

To Reproduce

Steps to reproduce the behavior:

  1. Use this dataset: Be more friendly with binary uuid phpmyadmin/phpmyadmin#16013 (comment)
  2. Double click to edit the relation like in the screenshot

Expected behavior

Dark

Additional context

  • phpMyAdmin version: 5.2
  • BooDark version: 1.1.0
@adorade adorade self-assigned this Jul 16, 2023
@adorade adorade added the bug Something isn't working label Jul 16, 2023
adorade added a commit that referenced this issue Jul 17, 2023
@adorade
fix(style): update cEdit background color
9a70ab3 
Close #51
@adorade adorade mentioned this issue Jul 17, 2023
Merged
@adorade
Copy link
Owner

adorade commented Jul 17, 2023

binary-uuid-dark

@williamdes I modified the code for cEdit in common.scss. If you can please check if it is what you expect. (see screenshot)

@williamdes
Copy link
Author

@williamdes I modified the code for cEdit in common.scss. If you can please check if it is what you expect. (see screenshot)

Thanks, it really looks good and nice !

@adorade
Copy link
Owner

adorade commented Jul 18, 2023

binary-uuid-input-focus-dark

Updated input style. I will merge PR in the next days and the fix will be included in the next release.

@williamdes
Copy link
Author

That's way better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adorade adorade

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix cEdit background color adorade/boodark
2 participants
@adorade @williamdes