-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update 2024-10-25-adr-templates.md #63
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even though the VS Code Plugin is outdated (supports MADR 2.x only), we can take the risk in linking.
Good point. I will mention this. |
Done. |
Added link and removed the space
I see that word repeated twice in the first sentence of the main page of MADR, too. It's existence has baffled me: |
We can remove it. And also remove the link to pronounciation - too distracting. Just keeping "decisions that matter". Or even remove the sub heading at all. |
Done. I think it's ready to be merged. @socadk |
We would need a new framework for this. The current "clean links" are a hack of the theme. I think, we need to switch ... again ... -> https://docusaurus.io/ |
@koppor can you please merge this PR? |
@koppor can you please merge this PR; because, I'm planning to add more improvements in another PRs. I've found some great tips and I would like to share them with readers. |
Added some explanation to make it easier for beginners.
Btw, I would say there need to be some button like "edit this page" to encourage people to contribute. As of now, one needs to search for relevant files in the repo then make changes. It's not intuitive.