Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 2024-10-25-adr-templates.md #63

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

azarboon
Copy link
Contributor

Added some explanation to make it easier for beginners.

Btw, I would say there need to be some button like "edit this page" to encourage people to contribute. As of now, one needs to search for relevant files in the repo then make changes. It's not intuitive.

@azarboon
Copy link
Contributor Author

@koppor and @socadk can you please review this PR so then we can proceed with best practices? BTW, please create a new section on the left hand menu name "Best practices" (or whatever you deem appropriate), so we can add to that.

Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though the VS Code Plugin is outdated (supports MADR 2.x only), we can take the risk in linking.

@koppor koppor requested a review from socadk November 22, 2024 07:13
@azarboon
Copy link
Contributor Author

Even though the VS Code Plugin is outdated (supports MADR 2.x only), we can take the risk in linking.

Good point. I will mention this.

@azarboon
Copy link
Contributor Author

Even though the VS Code Plugin is outdated (supports MADR 2.x only), we can take the risk in linking.

Good point. I will mention this.

Done.

Added link and removed the space
@azarboon
Copy link
Contributor Author

@koppor thanks for suggestion. Committed it.

May I ask, what's the purpose of having that bold part? I'm curious what's the rational behind it?

MADR is about architectural decisions that matter (mæɾɚ])

@azarboon
Copy link
Contributor Author

azarboon commented Nov 26, 2024

@koppor thanks for suggestion. Committed it.

May I ask, what's the purpose of having that bold part? I'm curious what's the rational behind it?

MADR is about architectural decisions that matter (mæɾɚ])

I see that word repeated twice in the first sentence of the main page of MADR, too. It's existence has baffled me:

image

@koppor
Copy link
Member

koppor commented Nov 28, 2024

I see that word repeated twice in the first sentence of the main page of MADR, too. It's existence has baffled me:

We can remove it. And also remove the link to pronounciation - too distracting. Just keeping "decisions that matter". Or even remove the sub heading at all.

@azarboon
Copy link
Contributor Author

I see that word repeated twice in the first sentence of the main page of MADR, too. It's existence has baffled me:

We can remove it. And also remove the link to pronounciation - too distracting. Just keeping "decisions that matter". Or even remove the sub heading at all.

Done. I think it's ready to be merged. @socadk

@koppor
Copy link
Member

koppor commented Nov 28, 2024

Btw, I would say there need to be some button like "edit this page" to encourage people to contribute. As of now, one needs to search for relevant files in the repo then make changes. It's not intuitive.

We would need a new framework for this. The current "clean links" are a hack of the theme.

I think, we need to switch ... again ... -> https://docusaurus.io/

@azarboon
Copy link
Contributor Author

@koppor can you please merge this PR?

@azarboon
Copy link
Contributor Author

azarboon commented Jan 1, 2025

@koppor can you please merge this PR; because, I'm planning to add more improvements in another PRs. I've found some great tips and I would like to share them with readers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants