Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tracer types #53

Merged
merged 7 commits into from
May 9, 2024
Merged

Refactor tracer types #53

merged 7 commits into from
May 9, 2024

Conversation

adrhill
Copy link
Owner

@adrhill adrhill commented May 7, 2024

Closes #40 by updating tracers to parametric signatures

  • ConnectivityTracer{I,S}
  • JacobianTracer{I,S}
  • HessianTracer{I,S,D}

Where I is the index type, S is a (pseudo-)set type and D is an AbstractDict{I,S}.

@adrhill adrhill requested a review from gdalle May 7, 2024 14:27
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2024

Codecov Report

Attention: Patch coverage is 51.81818% with 53 lines in your changes are missing coverage. Please review.

Project coverage is 70.62%. Comparing base (2fcd730) to head (5f033bf).

Files Patch % Lines
src/tracers.jl 64.70% 12 Missing ⚠️
src/settypes/recursiveset.jl 33.33% 10 Missing ⚠️
src/settypes/sortedvector.jl 33.33% 10 Missing ⚠️
src/settypes/base_sets.jl 47.05% 9 Missing ⚠️
src/settypes/duplicatevector.jl 33.33% 8 Missing ⚠️
src/conversion.jl 66.66% 2 Missing ⚠️
src/pattern.jl 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #53      +/-   ##
==========================================
- Coverage   71.35%   70.62%   -0.73%     
==========================================
  Files          11       12       +1     
  Lines         398      429      +31     
==========================================
+ Hits          284      303      +19     
- Misses        114      126      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrhill
Copy link
Owner Author

adrhill commented May 9, 2024

Merging for now, will be changed in #57.

@adrhill adrhill merged commit 0dd1bbd into main May 9, 2024
2 checks passed
@adrhill adrhill deleted the ah/type-refactor branch May 9, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HessianTracer type improvements
2 participants